Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD-884: Changed plugin storage name from dfs to dfs_test #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MD-884: Changed plugin storage name from dfs to dfs_test #318

wants to merge 1 commit into from

Conversation

prasadns14
Copy link
Contributor

@cchang738 and @Agirish Please review the changes

@prasadns14 prasadns14 self-assigned this Sep 9, 2017
@Agirish Agirish self-requested a review September 9, 2017 01:06
@Agirish
Copy link
Member

Agirish commented Sep 9, 2017

Thanks Prasad.

You will also need to change the name of the file -> conf/plugin-templates/dfs-storage-plugin.template to conf/plugin-templates/dfs_test-storage-plugin.template

@prasadns14
Copy link
Contributor Author

@Agirish
The cttas cases create temporary tables. Currently, temporary tables can be created only in the default temporary workspace dfs.tmp (https://gist.github.com/arina-ielchiieva/50158175867a18eee964b5ba36455fbf).

Should i revert the workspace name for cttas cases to dfs.tmp? Or do you have other suggestions?

@Agirish
Copy link
Member

Agirish commented Sep 9, 2017

The name of the storage plugin shouldn't matter. dfs_test.tmp should be equivalent to dfs.tmp. Do you see any issues?

@Agirish
Copy link
Member

Agirish commented Sep 9, 2017

Also, I took a look at as many files I could - looks good. But with lot of files, Guthub makes it hard. Running these tests (alongside the corresponding mapr private tests) on the Docker framework should give us more confidence. There may be areas which we have missed updating / reviewing.

@prasadns14 prasadns14 changed the title Changed plugin storage name from dfs to dfs_test MD-884: Changed plugin storage name from dfs to dfs_test Nov 14, 2017
@prasadns14 prasadns14 force-pushed the MD-884 branch 2 times, most recently from 3744e37 to 3821fef Compare January 6, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agirish Agirish Awaiting requested review from Agirish

At least 1 approving review is required to merge this pull request.

Assignees

@prasadns14 prasadns14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasadns14 @Agirish